Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel navigation focus #1242

Merged
merged 10 commits into from
Jun 1, 2022

Conversation

MewenLeHo
Copy link
Contributor

Closes #1084

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the js should be improved ? Maybe on Bs side

Focus on carousel doesn't seem to pause it
Focus on indicators is weird : the current page indicator is kinda scaled up

scss/_carousel.scss Outdated Show resolved Hide resolved
scss/_carousel.scss Show resolved Hide resolved
scss/_carousel.scss Outdated Show resolved Hide resolved
scss/_carousel.scss Show resolved Hide resolved
@MewenLeHo
Copy link
Contributor Author

I think the js should be improved ? Maybe on Bs side

Focus on carousel doesn't seem to pause it Focus on indicators is weird : the current page indicator is kinda scaled up

Should the carousel pauses on focus? Maybe. It may be useful for keyboard users.
What do you think about it @julien-deramond? It's a question for @Aniort and our accessibility experts.
However it's not the subject of this pull request.

@julien-deramond
Copy link
Member

Should the carousel pauses on focus? Maybe. It may be useful for keyboard users. What do you think about it @julien-deramond? It's a question for @Aniort and our accessibility experts. However it's not the subject of this pull request.

Not sure it should since you're focusing the arrow, not the carousel itself (the content). But I let @Aniort gives us his feedback.
Agree that's not something to take into account in this PR. As said by @louismaximepiton if we change this behavior let's propose it directly to Bootstrap.

@netlify
Copy link

netlify bot commented May 11, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 6416c92
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6297601cbc4edb0008d70d94
😎 Deploy Preview https://deploy-preview-1242--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus looks good to me 🚀

As discussed together, we can't use the $outline-width here because many outline-offset use this variable also we don't wanna change it now. It might introduce some issues that we don't want to handle before 5.2.0

@julien-deramond
Copy link
Member

For the PRs requiring a11y and/or design review, don't forget to mention it in the description otherwise we can't know if it's been done or not.

scss/_carousel.scss Outdated Show resolved Hide resolved
scss/_carousel.scss Show resolved Hide resolved
scss/_variables.scss Show resolved Hide resolved
scss/_carousel.scss Outdated Show resolved Hide resolved
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julien-deramond julien-deramond merged commit b3db327 into main Jun 1, 2022
@julien-deramond julien-deramond deleted the main-mewenleho-new-focus-carousel-navigation branch June 1, 2022 12:58
@julien-deramond julien-deramond mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODS > Navigation > Carousel Navigation
3 participants